modules: mcuboot: Fix missing chosen node lookup #97047
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
previously approved these changes
Oct 6, 2025
JarmouniA
reviewed
Oct 6, 2025
pdgendt
reviewed
Oct 6, 2025
Fixes an issue caused by using a chosen node string as a node rather than looking the node up first so it could be used Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
fixmissingchosenlookup
branch
from
f897647 to
1a6d40d
Compare
|
pdgendt
approved these changes
Oct 6, 2025
JarmouniA
approved these changes
Oct 6, 2025
gchwier
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
fixes issue with upgrading nrf54l15dk,
tested with command:
./scripts/twister -vv -ll debug -T tests/boot/with_mcumgr --west-flash=--recover -p nrf54l15dk/nrf54l15/cpuapp --device-serial /dev/ttyACM1 --device-testing --enable-slow -s boot.with_mcumgr.test_upgrade --pytest-args='-k test_upgrade_with_revert' -c
butok
approved these changes
Oct 6, 2025
1 task
de-nordic
approved these changes
Oct 7, 2025
JarmouniA
added
the
Hotfix
|
Blocking CI |
jhedberg
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue caused by using a chosen node string as a node rather than looking the node up first so it could be used